Repository navigation
fix(session): attribute selected-provider capabilities to the resolved identity - #2013
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Reviewed with fresh context from the issue and the #1988 thread. The shape matches the producing-representation rule: the identity is resolved once in One observation, not a blocker: the rebound |
|
CI note: the 7 failing tests on this PR (Electron identity acceptance, |
8deac58 to
add8ad5
Compare
…d identity Profile resolution gives Ghidra and Hopper a concrete version, but the selected candidate's capabilities and the session route kept the provider's static identity with a null version. binary_session therefore grouped capability sets under a different identity than the binding and the selected candidate. The registry now rebinds the selected provider's capabilities to the resolved identity once, on the binding, and the route uses them. Evidence provenance already compensated downstream by substituting the profile identity; that repair is removed because the route now carries the resolved identity. Fixes #2009 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
add8ad5 to
4554c5a
Compare
Fixes #2009
Problem
Profile resolution gives Ghidra and Hopper a concrete version. Their static identity has
version: null. After #1988 grouped capability facts by provider,binary_sessionput the selected provider's capability sets (top-level and on the selected candidate) under the static identity. The binding and the selected candidate'sprovideruse the resolved one. The same provider therefore appeared under two identities, and its capability facts lost the known version. Codex raised this on #1988 and nobody followed up.Change
AnalysisProviderRegistry.selectedResultrebinds the selected provider's capabilities to the resolved profile identity once. It stores them on the binding (AnalysisProviderBinding.capabilities) and on the selected candidate status.SessionProviderRouterbuilds route capabilities from the auxiliary providers plus the binding's rebound capabilities. Operation routing still goes through the provider itself.BinarySession.providerIdentityandDirectAnalysis.providerIdentityForRouteused to swap in the profile identity downstream. The route now carries the resolved identity, so that repair is gone.Contract impact: the
provider.versionvalues inbinary_sessioncapability sets now matchanalysis_provider_binding.providerfor the selected provider. The schema is unchanged.Validation
tests/composition/analysis-sessions/providerBinding.test.ts, using the existing deep-provider fixture: staticversion: null, resolved"1". It fails on the base commit withversion: nullin the selected candidate's capability set, and passes with this change.npm run lintpasses, andtsc --noEmitpasses.npm test: 8,613 passed and 12 failed. The 12 failures are in 5 files:interfaceBuilderBundle,nibNativeHierarchy,javascriptRuntimeObservation,javascriptRuntimeTargetLocationsandnativeDmgArtifactReader. They fail identically on the unchanged base commit on this host (macOS, Command Line Tools only, no ibtool), so they are environmental and unrelated to this change.Real-provider scope: verified only with the simulated provider fixture. No real Ghidra or Hopper run was done.
🤖 Generated with Claude Code